Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null labelName for many subdomains #62

Open
graemecode opened this issue Dec 15, 2022 · 1 comment
Open

Null labelName for many subdomains #62

graemecode opened this issue Dec 15, 2022 · 1 comment

Comments

@graemecode
Copy link

graemecode commented Dec 15, 2022

Hi there,

I was investigating the issue with the labelName being null for some subdomains and I came across the code responsible in the ensRegistry.ts file. It appears to be happening in lines 53 to 56 in the fbddf98 version.

let label = ens.nameByHash(event.params.label.toHexString())
if (label != null) {
domain.labelName = label
}

I was wondering if this is a known issue and if there is anything that can be done to fix it. I've included some examples below.

Please let me know if you have any thoughts or insights on this matter.

Examples

LabelName is null
Screen Shot 2022-12-14 at 10 51 42 PM

LabelName is correct
Screen Shot 2022-12-14 at 10 51 47 PM

@graemecode graemecode changed the title labelName subdomain issue Null labelName for many subdomains Dec 15, 2022
@graemecode
Copy link
Author

Perhaps this is related to this issue #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant