Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Starknet cointype #363

Closed
makoto opened this issue Nov 15, 2022 · 0 comments
Closed

Support Starknet cointype #363

makoto opened this issue Nov 15, 2022 · 0 comments

Comments

@makoto
Copy link
Member

makoto commented Nov 15, 2022

Here is the encoding/validation logic: https://github.com/0xs34n/starknet.js/blob/develop/src/utils/address.ts

Example: https://github.com/ensdomains/address-encoder/pull/47/files

Please provide a reference link so we can check you did the encoding correctly.

We'd like to keep the encoding library as small as possible, so please be efficient in your use of space. If your PR expands the file size of the library too much, we won't accept it.

Checklist:

Please follow the list below before submitting your PR

  • My code follows the code style of this project.
  • My code implements all the required features.
  • I have specified correct coinTypes specified at Slip 44
  • I have provided the reference link to the specification I implemented.
  • I have provided enough explanation about how I provided the test address
@makoto makoto mentioned this issue Nov 29, 2022
5 tasks
@makoto makoto closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant