Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Sensors from Web dashboard to it's own tab #1170

Closed
proddy opened this issue May 6, 2023 · 2 comments
Closed

Move Sensors from Web dashboard to it's own tab #1170

proddy opened this issue May 6, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request technical Technical enhancement, or tech-debt issue
Milestone

Comments

@proddy
Copy link
Contributor

proddy commented May 6, 2023

I've moved Sensors from the Dashboard Data & Sensors to its own tab and changed 'dallas' to 'temperature' in the API. The reasons being

  • eventually we should support more than just the Dallas DS18b20 sensors, like DHT11, DHT22, LM35, BME280, BMP180 etc
  • in discussing with BBQKees we have ideas to extend Sensors with more types
  • the Add Analog sensor button (which was a + in the table) was a bit odd and not consistent with the rest of the styling, with an explicit 'Add' button
  • it keeps the code tidier

The change from 'dallassensor' to 'temperaturesensor' is a breaking change. Old MQTT topics would need to be removed and any HA pages updated. Also I expect any integrations that don't use MQTT Discovery like IOBroker would also need updating.

@proddy proddy added enhancement New feature or request technical Technical enhancement, or tech-debt issue labels May 6, 2023
@proddy proddy added this to the v3.6.0 milestone May 6, 2023
@proddy proddy self-assigned this May 6, 2023
@proddy
Copy link
Contributor Author

proddy commented May 6, 2023

The new tab is in PR #1162

@proddy
Copy link
Contributor Author

proddy commented May 25, 2023

in dev11

@proddy proddy closed this as completed May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request technical Technical enhancement, or tech-debt issue
Projects
None yet
Development

No branches or pull requests

1 participant