Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom telegram handler #1155

Closed
proddy opened this issue Apr 7, 2023 Discussed in #1079 · 5 comments
Closed

custom telegram handler #1155

proddy opened this issue Apr 7, 2023 Discussed in #1079 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@proddy
Copy link
Contributor

proddy commented Apr 7, 2023

Discussed in #1079

Originally posted by proddy January 21, 2023
from @tp1de

Very long time ago I made a proposal to introduce "customizable" entities by telegram-type and offset. Maybe still an idea to support special installations and requirements.

I don't recall that, but its really good idea. We could add to the Customization page the ability to add a new Telegram to the EMS device in which you choose a name, the type (short, int), the divider (div10, div2 etc) and position. This would only be for read telegrams though.

Originally posted by @proddy in #908 (comment)

@proddy proddy added the enhancement New feature or request label Apr 7, 2023
@proddy
Copy link
Contributor Author

proddy commented Apr 7, 2023

Michael created this in #1151

@proddy proddy added this to the v3.6.0 milestone Apr 7, 2023
@proddy
Copy link
Contributor Author

proddy commented Apr 7, 2023

@MichaelDvP the webUI needs a little tidying up and also some mock data in server.js. Shall I do this?

@MichaelDvP
Copy link
Contributor

Yes, please do this.

@proddy
Copy link
Contributor Author

proddy commented Apr 7, 2023

Yes, please do this.

I've been working on the web code, making minor changes and then decided to look at replacing all the form validation code with a new library, and at the same time refactoring the component rendering since it's really quite inefficient (many renders). So it's going to take some time. I'm checking it into my local repo

@proddy
Copy link
Contributor Author

proddy commented Apr 23, 2023

think we can close this. The updated web code is in PR #1162

It's a great feature, thanks.

@proddy proddy closed this as completed Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants