From 917e268ac964bbf77d483d0efa50cb482a8dd6b9 Mon Sep 17 00:00:00 2001 From: Proddy Date: Sat, 23 Sep 2023 18:41:54 +0200 Subject: [PATCH] add TODO on possible memory out-of-bounds error --- src/devices/thermostat.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/devices/thermostat.cpp b/src/devices/thermostat.cpp index 7ff89a49f..8954af83a 100644 --- a/src/devices/thermostat.cpp +++ b/src/devices/thermostat.cpp @@ -843,6 +843,8 @@ void Thermostat::process_RC35wwTimer(std::shared_ptr telegram) { if (telegram->type_id != 0x38) { return; } + + // TODO: should this be >= 87 to avoid out of bounds? if (telegram->message_length + telegram->offset >= 92 && telegram->offset <= 87) { char data[sizeof(wwVacation_)]; snprintf(data,