We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emotion
react
Relevant code.
cx('guyFieri', { donkeySauce: true, })
What you did:
I want to replace classnames with cx
classnames
cx
What happened:
There is extra whitespace at the end of the class names.
Reproduction:
Just use cx
Problem description:
If you have hundreds of components, this creates unnecessary snapshot churn, and feels/smells like a code smell.
Suggested solution:
Trim whitespace from className or alter existing logic to not always push trailing whitespace on the next local var
next
The text was updated successfully, but these errors were encountered:
I can't seem to reproduce this. https://codesandbox.io/s/6xjk5p5n03
Sorry, something went wrong.
sorry about that, here is a codesandbox with examples of extra whitespace: https://codesandbox.io/s/oop6pz4w25
If the default props are set to null, but are of type PropTypes.string, snapshots will render null as a string
null
PropTypes.string
Successfully merging a pull request may close this issue.
emotion
version: 9.0.0-1react
version: 16.2Relevant code.
What you did:
I want to replace
classnames
withcx
What happened:
There is extra whitespace at the end of the class names.
Reproduction:
Just use cx
Problem description:
If you have hundreds of components, this creates unnecessary snapshot churn, and feels/smells like a code smell.
Suggested solution:
Trim whitespace from className or alter existing logic to not always push trailing whitespace on the
next
local varThe text was updated successfully, but these errors were encountered: