Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken Links #411

Closed
trainorpj opened this issue Oct 16, 2017 · 3 comments
Closed

Broken Links #411

trainorpj opened this issue Oct 16, 2017 · 3 comments

Comments

@trainorpj
Copy link

trainorpj commented Oct 16, 2017 •
edited
Loading

Problem description:

Some of the links in the full documentation page are broken. Specifically

Suggested solution:

I'm happy to work on this. I just used emotion for the first time in a project (big fan! 👩‍🎤), so I'm familiar with it. I figured the best approach would be to make (small) pages for each one.
@greggb
Copy link
Member

greggb commented Oct 16, 2017

I folded those pages into other sections. I'm no longer seeing the links in your issue on that page. If you find a 404 please let me know!

@greggb greggb mentioned this issue Oct 16, 2017
Merged
@greggb
Copy link
Member

greggb commented Oct 17, 2017

Ah, I see it now - should be fixed in #412

@tkh44
Copy link
Member

tkh44 commented Oct 17, 2017

Thank you @trainorpj for bringing this to our attention. Thank you @greggb for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@greggb @tkh44 @trainorpj