Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover API attributes as valid props #3299

Open
EnzoAlbornoz opened this issue Dec 19, 2024 · 1 comment · May be fixed by #3306
Open

Popover API attributes as valid props #3299

EnzoAlbornoz opened this issue Dec 19, 2024 · 1 comment · May be fixed by #3306
Labels
feature request needs triage

Comments

@EnzoAlbornoz
Copy link

The problem

Currently, there is no support for popover API properties in @emotion/is-prop-valid. So these properties are dropped, and the final component doesn't work.

Proposed solution

Include Popover API properties (popover, popovertarget, and popovertargetaction) in the valid props list.

Additional context
@EnzoAlbornoz EnzoAlbornoz changed the title Popover API support Popover API as valid props Dec 19, 2024
@EnzoAlbornoz EnzoAlbornoz changed the title Popover API as valid props Popover API attributes as valid props Dec 19, 2024
@p4privacy
Copy link

finded

@EnzoAlbornoz EnzoAlbornoz linked a pull request Jan 13, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(is-prop-valid): add support for popover api EnzoAlbornoz/emotion
2 participants
@EnzoAlbornoz @p4privacy