-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash on file read, Julia 1.11 #16
Comments
Which version of |
I was using the released version in the General Registry, but I just now installed the I ran the MWE 4 times:
So it seems that even with |
Maybe this has something to do with the fact that the fundamental underlying structure of Arrays in Julia 1.11 has changed? Does OIFITS (or maybe FITSIO) interface with Arrays at a lower-level than it is "supposed to"? See: JuliaLang/julia#51319 - listed at the very top of the Julia 1.11 Release News |
To solve this kind of issues (and others), I plan to use EasyFITS.jl instead of FITSIO.jl. I will start a new branch with these changes as soon as possible.. |
BTW I also had this problem with Julia 1.11.0-beta1 although I can correctly open the file with FITSIO... |
Great, thanks. I will continue using Julia 1.10 for the time being then. Yes, I also did not see a crash in FITSIO during regular usage under Julia 1.11, so it is possible that the problem was mis-diagnosed. (However, when running |
I have tried to read a file with Since I do not have my hands in |
As of 6546ff0, all tests passed with
|
Thanks, I'll give it a try! |
I am not running into any issues with OIFITS after playing around with this for a little bit. Thank you very much for all of your work! I am very impressed that you replaced the entire underlying library without modifications to the OIFITS API. Fantastic! I will mark this issue as closed. P.S. I know that FITSHeaders will soon be added to the Julia General registry, but could you also add it to your personal registry in the meantime? Thanks! |
When I try to read in files with Julia 1.11, I sometimes (most of the time in fact) get a crash. Usually, Julia crashes outright, but sometimes there is a conversion error, and sometimes I get a partial error message but the file read continues fine, and sometimes there is no error at all. I reproduce this error in Windows 11 and Ubuntu Linux. I have never seen this error in Julia <1.10.
MWE:
Crash on Windows
Segmentation fault in Linux
Keyword conversion error (occurs in Windows and Linux). Not always "OI_REVN", have also seen other keywords throw the same error
Partial error but then recovers and reads the file (only seen in Windows a couple times, but perhaps I haven't tried enough times in Linux)
Sometimes, the file is read just fine with no issues (both in Windows and Linux)
Probably related: JuliaLang/julia#52951
The text was updated successfully, but these errors were encountered: