Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bracket Emmet Plugin breaks Brackets intellisense and Find in Files-Replaces functionality #146

Closed
ahmetus opened this issue Jan 18, 2013 · 8 comments

Comments

@ahmetus
Copy link

ahmetus commented Jan 18, 2013

These issues happen with Bracket 18
For intellisense issue you can look here : adobe/brackets#2455
When I activate this plugin, it also breaks find in files and find and replace functionality in Bracket. You can also see screenshot for this issue in here: https://www.evernote.com/shard/s144/sh/7176b0d4-bb08-4684-acc6-6e952a44613d/d4b687a4f2d09114b179cfc1e3051d21

I also added this issue to Bracket repo issues.

Best regards..

@ahmetus
Copy link
Author

ahmetus commented Jan 18, 2013

adobe/brackets#2607
Find in Files and Search and Replaces issues solved. Latest Emmet build handle this. But intellisense issue still there.

@peterflynn
Copy link

Note: Brackets is also tracking the code hinting issue, via adobe/brackets#2455.

@sergeche
Copy link
Member

I’ve fixed this issue a while ago as @redmunds suggested: adobe/brackets#2357
The GitHub disabled uploads so I can’t update downloadable plugin for now. I have to create a separate repo for this. But you can create plugin from current repo by running ant plugin.brackets from repo root (Apache Ant required).

@ahmetus
Copy link
Author

ahmetus commented Jan 21, 2013

Yes, I saw and did that. Then issue solved like you suggest. Thanks but intellisense issue still exist: adobe/brackets#2455

@sergeche
Copy link
Member

I think it should be fixed on Brackets part.

My suggestion is to use context for key bindings, like in Sublime Text 2. For example, to properly override Tab key in editor, I’ve defined has_next_field == false context property to make sure that key handler won’t work if there are active tabstops/fields. Context properties is really powerful way to filter out key binding scopes. You can create something like widget_visible property so I can disable my keybindings if autocomplete widget is visible.

@ahmetus
Copy link
Author

ahmetus commented Jan 22, 2013

@sergeche If I set to tabkey other than real tab key in Emmet Plugin Keybindings, then intellisense works but just with tab key, I can't use enter key for auto completion. It's temporary solution. I hope they consider what you are suggest in next release of Brackets. Thanks for your guidance.

@ahmetus
Copy link
Author

ahmetus commented Jan 22, 2013

I installed Bracket Sprint 19, issue still there.

@ahmetus
Copy link
Author

ahmetus commented Jan 23, 2013

adobe/brackets#2455 (comment)

@sergeche I forked your work and tested. It works by all means, even with tab key and did not break intellisense or finding replacing. Issue solved. Thank you for your great effort and all interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants