Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To strong name or not #10

Closed
emertechie opened this issue Nov 27, 2015 · 5 comments
Closed

To strong name or not #10

emertechie opened this issue Nov 27, 2015 · 5 comments

Comments

@emertechie
Copy link
Owner

Received a request to strong name the assembly so adding an issue for discussion.

I've always found strong naming pretty painful myself, and I know it leads to a lot of debate. See this comment and Microsoft's own recommendations here also.

So I'd naturally lean against it but if there's a genuine need, and someone is willing to do a pull request and merge it (cough, cough @grubman :) ) then fine by me.

@dmitry-shechtman
Copy link

Please do.

If you're really opposed to it, you may release the signed package separately as SyslogNet.Client.Signed, in the worst of NuGet tradition :)

Let me know what you think, and whether you want me to do the PR.

@grubman
Copy link
Collaborator

grubman commented Dec 1, 2015

I have no problem to merge and check it. I have a fairly busy week, so I'll find some time to read the links and decide how to release it only next week :)

@dmitry-shechtman
Copy link

I fail to see any problem with releasing just the strongly named one, given that the private key used for signing it is public.

@dmitry-shechtman
Copy link

#11

@grubman
Copy link
Collaborator

grubman commented Feb 16, 2017

a lot of time have passed, and no PR was presented. closing it...

@grubman grubman closed this as completed Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants