Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiled CSS not updating in app #309

Closed
josemarluedke opened this issue Aug 17, 2019 · 3 comments
Closed

Compiled CSS not updating in app #309

josemarluedke opened this issue Aug 17, 2019 · 3 comments

Comments

@josemarluedke
Copy link
Collaborator

In a nearly created Ember App using Ember CLI 3.13 beta and adding Embroider (v0.6.0), changing styles in the app.css file does not reflect in the running application.

In the reproduction below, changing the app.css will trigger a rebuild of the app, but the content of the compiled CSS file does not change. If I restart the app (kill ember s and re-run), it will have the changes applied.

Initially, I thought this was only for sass, but while creating the reproduction, I saw it was for plain CSS as well.

Reproduction: https://github.com/josemarluedke/--embroider-css-bug

@josemarluedke
Copy link
Collaborator Author

I have tried to figure out what's happening, but I wasn't able to find anything concrete.

I didn't find any code related to updating assets when files changes.

There is this line for updating assets:

let finalAssets = await this.updateAssets(assets, appFiles, emberENV);

but the appFiles passed in are coming from
let appFiles = this.updateAppJS(this.adapter.appJSSrcDir(inputPaths));

which seems to filter just JS files.

Enabling logs I can see that the app differ didn't find any changes:

embroider:debug app-differ operations count: 0 +20s.

Anyway, would love some help to fix this issue.

@imkathir
Copy link

I've encountered this issue in my app as well

@josemarluedke
Copy link
Collaborator Author

This has been fixed in the recent PR #342.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants