From 5fa79bc39749949f5d5f7ef6298fc50fcbe94efd Mon Sep 17 00:00:00 2001 From: Erik Bryn Date: Wed, 25 May 2011 19:45:25 -0700 Subject: [PATCH 1/2] Alter SC.Button mouseUp event to return false to avoid form submissions. --- packages/sproutcore-handlebars/lib/controls/button.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/sproutcore-handlebars/lib/controls/button.js b/packages/sproutcore-handlebars/lib/controls/button.js index 64fb96f1045..b6d7395073f 100644 --- a/packages/sproutcore-handlebars/lib/controls/button.js +++ b/packages/sproutcore-handlebars/lib/controls/button.js @@ -59,6 +59,7 @@ SC.Button = SC.View.extend({ this._mouseDown = false; this._mouseEntered = false; + return false; }, // TODO: Handle proper touch behavior. Including should make inactive when From 9eab4f2b8dc19cada7e3fc5434c1b102a4cffdac Mon Sep 17 00:00:00 2001 From: Erik Bryn Date: Thu, 2 Jun 2011 12:49:05 -0700 Subject: [PATCH 2/2] Typo in sproutcore-metal docs --- packages/sproutcore-metal/docs/NOTES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/sproutcore-metal/docs/NOTES.md b/packages/sproutcore-metal/docs/NOTES.md index 2ee8aeb89f8..d20aa5c9d71 100644 --- a/packages/sproutcore-metal/docs/NOTES.md +++ b/packages/sproutcore-metal/docs/NOTES.md @@ -355,7 +355,7 @@ notifications and other actions. In order to do this it relies on a newer feature in JavaScript environments called __getters and setters__. All browsers in common usage support getters and setters except for IE7 and 8. -In particular, all mobile browsers support the, which is why we think now is +In particular, all mobile browsers support them, which is why we think now is the time to start to use them. If you need to support IE7 and 8 however, you cannot rely on the getter and