Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.17] [REGRESSION] re-rendering an {{#each}} with multiple null values only renders one iteration #18864

Closed
bendemboski opened this issue Apr 8, 2020 · 1 comment · Fixed by #18941

Comments

@bendemboski
Copy link
Contributor

When updating an {{#each}}-rendered array to be [ null, null, null ], only one iteration of the array is rendered, as if it just contained [ null ]. This rendering test passes in 3.16 and fails in 3.17:

  test('rerendering array of nulls works', async function(assert) {
    this.set('items', [ false, false, false ]);
    await render(hbs`
      {{#each this.items as |item|}}
        <p>item: {{item}}</p>
      {{/each}}
    `);
    assert.dom('p').exists({ count: 3 });

    this.set('items', [ null, null, null ]);
    await settled();
    assert.dom('p').exists({ count: 3 });
  });

here is an app that reproduces the issue and demonstrates that it's a regression since 3.16.

@pzuraq
Copy link
Contributor

pzuraq commented Apr 29, 2020

Bugfix submitted upstream, pending review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants