Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in-element helper not working #16886

Closed
ashrafmajdee opened this issue Aug 15, 2018 · 3 comments
Closed

in-element helper not working #16886

ashrafmajdee opened this issue Aug 15, 2018 · 3 comments

Comments

@ashrafmajdee
Copy link

in-element helper is throwing the following error

Uncaught TypeError: parent.insertBefore is not a function

i'm using ember version 3.3.1

@ashrafmajdee
Copy link
Author

finally got this to work by passing the element from a computed property.

@btecu
Copy link
Contributor

btecu commented Aug 15, 2018

Indeed, I brought up this point in the RFC emberjs/rfcs#287 but it was decided to go forward anyway. Most users will get tripped by this, since almost always you want to pass a selector, not a node.

@ashrafmajdee
Copy link
Author

for me it only works when the element is returned from a computed property. if it's not from a computed property it doesn't work, don't know why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants