Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller.replaceRoute does not work in an Engine #15179

Closed
spencer516 opened this issue Apr 27, 2017 · 2 comments
Closed

controller.replaceRoute does not work in an Engine #15179

spencer516 opened this issue Apr 27, 2017 · 2 comments
Labels
Has PR Routing

Comments

@spencer516
Copy link
Contributor

When using the replaceRoute method in a Controller inside of an Engine, the engine's mount point is not prefixed to the route name leading to a "not route defined" error.

It appears it's a small bug that unintentionally used the incorrect argument. I've opened a PR here:

#15176
@Serabe
Copy link
Member

Serabe commented Apr 27, 2017

Thank you!

@Serabe Serabe added the Has PR label Apr 27, 2017
@Serabe Serabe added the Routing label Jul 13, 2017
@spencer516
Copy link
Contributor Author

Fixed by #15176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Has PR Routing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Serabe @spencer516