Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio buttons render as a text input in IE8 #12295

Closed
jerel opened this issue Sep 4, 2015 · 11 comments
Closed

Radio buttons render as a text input in IE8 #12295

jerel opened this issue Sep 4, 2015 · 11 comments

Comments

@jerel
Copy link
Contributor

jerel commented Sep 4, 2015

Here is a very tiny example: http://emberjs.jsbin.com/kiyesi

<input type="radio"> of course renders fine in IE8 but rendering the same minimal example dynamically via a component results in a text input instead:

App.RadioCheckComponent = Ember.Component.extend({
  tagName: 'input',
  type: 'radio',
  attributeBindings: ['type'],
});

I just upgraded from Ember v1.12.x and the problem did not exist there.

@pixelhandler
Copy link
Contributor

@jerel Is there a quick way for someone to see this emulated in IE8 (don't personally have a PC) ?

@jherdman
Copy link
Contributor

jherdman commented Sep 4, 2015

https://github.com/xdissent/ievms ought to help you out.

@pixelhandler
Copy link
Contributor

@jherdman I was curious if there was anything quicker (than installing) perhaps web based. Really don't want to install IE8 :(

@jerel
Copy link
Contributor Author

jerel commented Sep 4, 2015

@pixelhandler here is a screenshot of the result and the code:
ie8

As far as I can tell the resulting html is correct. I've compared between my v1.12.x and v1.13.x versions. I'm guessing it has something to do how the element is created (timing of when the type is added perhaps) but that's just a guess.

@ef2k
Copy link

ef2k commented Sep 4, 2015

@pixelhandler There's the free trial browserstack offers: https://www.browserstack.com/

@rwjblue
Copy link
Member

rwjblue commented Sep 4, 2015

This is likely the same as tildeio/htmlbars#380 which came from #11553.

@pixelhandler
Copy link
Contributor

@eddflrs yeah would be cool if could group fund browserstack for ember debugging as a community

@pixelhandler
Copy link
Contributor

@jerel yeah <input id="ember304" type="radio" class="ember-view"> is not the same as <input id="ember304" type="radio" class="ember-view"></input> but other browsers do display that correctly either way.

@jerel
Copy link
Contributor Author

jerel commented Sep 4, 2015

This does appear to be caused by Ember trying to set type after the element is in the DOM.

As a temporary workaround I implemented a component with tagName: '' and put <input type="radio" dynamic="{{foo}}"> in its template and that works.

@gauthierm
Copy link

This should be fixed in the latest #12351

@rwjblue
Copy link
Member

rwjblue commented Nov 12, 2015

Fixed by #12596.

@rwjblue rwjblue closed this as completed Nov 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants