Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop polyfill idea? #11

Closed
Turbo87 opened this issue Nov 9, 2017 · 2 comments
Closed

Drop polyfill idea? #11

Turbo87 opened this issue Nov 9, 2017 · 2 comments
Labels

Comments

@Turbo87
Copy link
Member

Turbo87 commented Nov 9, 2017

Similar to emberjs/ember-ordered-set#14 it looks like Ember.Map has quite a few API differences to the native Map class. As argued in emberjs/ember-ordered-set#14 (comment) it might make sense to restrict this package to just mirror Ember.Map and not try to polyfill the native Map too. In that case we should drop the -polyfill suffix from the project name though.

@Turbo87
Copy link
Member Author

Turbo87 commented Nov 9, 2017

renaming to @ember/map would also satisfy the new import paths (see https://github.com/ember-cli/ember-rfc176-data/#embermap), though it might create problems for @ember/map/with-default 🤷‍♂️

@Turbo87
Copy link
Member Author

Turbo87 commented Nov 14, 2017

Given emberjs/data#5255 and our discussion on Slack I'll close this issue now because we will archive the project again. By the time Ember.js will drop Ember.Map Ember will be at version 3.x, and at that point all target platforms (even IE11) have support for the native Map class, which is a better migration path than using @ember/map-polyfill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant