Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ember Data 4.7] Models disappear when more than 2400 instances #8263

Closed
mkszepp opened this issue Oct 27, 2022 · 2 comments · Fixed by #8264
Closed

[Ember Data 4.7] Models disappear when more than 2400 instances #8263

mkszepp opened this issue Oct 27, 2022 · 2 comments · Fixed by #8264
Labels
🏷️ bug This PR primarily fixes a reported issue

Comments

@mkszepp
Copy link
Contributor

mkszepp commented Oct 27, 2022

Description

While creating the example repository for a other bug (#8262) i have deteced this bug (which is present in the repository https://github.com/mkszepp/ember-stable-identifier)
When i have 2400 models in store and add model n. 2401, other models will be lost.
After removing a model all other models return.
When i readd model n. 2401, the .length returns a wrong number of models.
This problem is not present in ember 4.4 with ember data 4.4.

Versions

Ember Js: 4.7.0+
Ember Data: 4.7.3
Test on Browser: latest Chrome + Firefox

@mkszepp mkszepp changed the title [Ember Data 4.7] Model disappear when more than 2400 [Ember Data 4.7] Models disappear when more than 2400 instances Oct 28, 2022
@runspired
Copy link
Contributor

runspired commented Oct 28, 2022

do you have a reproduction for this? or just a list of steps?

the only thing that stands out here as intriguing is that 2400 is exactly twice the size of our slice increment when we copy from source-array to proxied-array.

@runspired
Copy link
Contributor

Found bug, have fix

@runspired runspired added the Bug label Oct 28, 2022
@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue and removed Bug labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants