Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model.eachTransformedAttribute not under test coverage / broken 3.28+ #7969

Closed
runspired opened this issue Apr 21, 2022 · 2 comments · Fixed by #8346
Closed

Model.eachTransformedAttribute not under test coverage / broken 3.28+ #7969

runspired opened this issue Apr 21, 2022 · 2 comments · Fixed by #8346
Labels
🏷️ bug This PR primarily fixes a reported issue

Comments

@runspired
Copy link
Contributor

Recently discovered that this method was implemented incorrectly on ShimModelClass which is what we began handing out to adapters/serializers in 3.28. This means starting in 3.28+ transforms would not have been applied correctly during normalization.

I've fixed this on the typescript branch (thank you typescript for surfacing!) but we should port a fix to 3.28 / release and also add some tests.
@geneukum
Copy link

geneukum commented May 5, 2022

Hey @runspired, I don’t mind taking a look at this one. What is the name of the typescript branch?

@runspired
Copy link
Contributor Author

@geneukum #7957

@runspired runspired mentioned this issue Dec 8, 2022
Merged
@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue and removed Bug labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Schema.eachTransformedAttribute API should match Model.eachTransformedAttribute emberjs/data
2 participants
@runspired @geneukum