Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document instantiateRecord and RFC#487 custom model class APIs #7055

Closed
1 task done
hjdivad opened this issue Feb 19, 2020 · 1 comment · Fixed by #8114
Closed
1 task done

Document instantiateRecord and RFC#487 custom model class APIs #7055

hjdivad opened this issue Feb 19, 2020 · 1 comment · Fixed by #8114
Labels
feature-suggestion 🏷️ doc This PR adds/improves/or fixes documentation 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166

Comments

@hjdivad
Copy link
Member

hjdivad commented Feb 19, 2020

Action Items:

We've had discussions the last couple meetings about how to refer to model classes in the face of

  • The DS namespace going away in favour of packages and
  • Model being ambiguous between @ember-data/model and the user-specified return from instantiateRecord

The upshot is to refer to @ember-data/model specifically and to separately add documentation for implementing custom model classes, part of which requires coming up with clear names to describe generic records.

Custom model classes is an advanced feature that shouldn't be part of the onboarding guides. A reasonable place to put this sort of thing might be under Additional Resources -> Advanced -> Custom Model Classes on https://guides.emberjs.com/release/

cc @rwjblue @igorT @runspired @efx

@runspired runspired added the 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 label May 20, 2021
@runspired runspired changed the title Document CUSTOM_MODEL_CLASS Document instantiateRecord and RFC#487 custom model class APIs May 20, 2021
@runspired runspired moved this to Fix | TODO in EmberData Feb 18, 2022
@runspired
Copy link
Contributor

Documented in #8114

@runspired runspired linked a pull request Aug 11, 2022 that will close this issue
Repository owner moved this from Fix | TODO to RFC | Needs Implemented in EmberData Aug 11, 2022
@runspired runspired added feature-suggestion 🏷️ doc This PR adds/improves/or fixes documentation and removed Feature labels Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-suggestion 🏷️ doc This PR adds/improves/or fixes documentation 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants