Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecations for Enumerable#contains usage. #4504

Closed
rwjblue opened this issue Aug 21, 2016 · 3 comments
Closed

Deprecations for Enumerable#contains usage. #4504

rwjblue opened this issue Aug 21, 2016 · 3 comments

Comments

@rwjblue
Copy link
Member

rwjblue commented Aug 21, 2016

In Ember 2.8.0-beta.1+ the ember-runtime-enumerable-includes feature is enabled (read more about it in the RFC). Many deprecations are triggered by Ember Data.

It would be great to get this fixed before ember-data@2.8.0 stable is released, though I haven't dug into how much work it would be to fix.

@rwjblue
Copy link
Member Author

rwjblue commented Aug 25, 2016

I created https://github.com/rwjblue/ember-runtime-enumerable-includes-polyfill to make this a bit easier for Ember Data (and other addons) to avoid deprecations, use the newer syntax, and not trigger deprecations.

@pangratz
Copy link
Member

pangratz commented Sep 1, 2016

I guess this is fixed by #4519 and can be closed, right?

@bmac
Copy link
Member

bmac commented Sep 1, 2016

Yes.

@bmac bmac closed this as completed Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants