-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
headers being a CP may be a poor choice #4496
Comments
The ds-improved-ajax feature flag (enabled in the current beta) adds a new headersForRequest method that will become the recommended way to handle this usecase. Users will be encouraged to override |
Very awesome. Should we close this issue when:
Or consider it solved, and close it now? |
I'm in favor of closing this when the docs have been updated to encourage the new flow. |
As we never landed DS-improved-Ajax and as headers is no longer a volatile property in going to close this. |
data/addon/adapters/rest.js
Lines 215 to 228 in c6d233b
Volatile is strange, specifically in a world of templates it has a complex meaning and for this use-case a function instead of a CP would more then likely be what we want.
Other motivation is attempting roll back the concept of
.volatile
some the public API, as most of the time when it is required, it is the source of something else being funky.cc @krisselden
The text was updated successfully, but these errors were encountered: