Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any chance we could get a v1.13.12? #3752

Closed
workmanw opened this issue Sep 10, 2015 · 4 comments
Closed

Any chance we could get a v1.13.12? #3752

workmanw opened this issue Sep 10, 2015 · 4 comments

Comments

@workmanw
Copy link

One of our enterprise customers has their user's locked to Firefox 31 (I realize this is generally not supported). They're completely unable to use our app at the moment due to an issue with Ember Inflector that has since been fixed. See: emberjs/ember-inflector#89 . The app is completely crashing for all users at this customer site :(

I'd really like to get a new build of Ember-Data that includes this fix. I did a local build from the 1.13 release branch and confirmed it does fix this issue.

I'd be happy to do all the leg work. I'm just not sure how to formally go about this. Should I submit a PR w/ build to the https://github.com/components/ember-data repo?

@bmac
Copy link
Member

bmac commented Sep 10, 2015

Hi @workmanw. I can do a build and a release. Before I do would you mind submitting a pr to ensure Ember Data has the requires a version of ember-inflector in its pacakge.json with that fix https://github.com/emberjs/data/blob/release-1-13/package.json#L59?

Thanks

@workmanw
Copy link
Author

@bmac Yeap, I'm on it. Thank you!!!

@bmac
Copy link
Member

bmac commented Sep 10, 2015

v1.13.12 has been released and published to bower.

@bmac bmac closed this as completed Sep 10, 2015
@workmanw
Copy link
Author

Thanks again! I owe you 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants