From e1daa634d86384763ca0d65750d83524e53de08e Mon Sep 17 00:00:00 2001 From: Joshua Cope Date: Fri, 19 Jun 2015 18:30:34 -0400 Subject: [PATCH] make sure deprecate error doesnt get swallowed when using store.push(type, data) --- packages/ember-data/lib/system/store.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ember-data/lib/system/store.js b/packages/ember-data/lib/system/store.js index 28a3a2b2fbc..e96f54ad67b 100644 --- a/packages/ember-data/lib/system/store.js +++ b/packages/ember-data/lib/system/store.js @@ -1773,11 +1773,11 @@ Store = Service.extend({ if (Ember.typeOf(modelNameArg) === 'object' && Ember.typeOf(dataArg) === 'undefined') { data = modelNameArg; } else { + Ember.deprecate('store.push(type, data) has been deprecated. Please provide a JSON-API document object as the first and only argument to store.push.'); Ember.assert("Expected an object as `data` in a call to `push` for " + modelNameArg + " , but was " + Ember.typeOf(dataArg), Ember.typeOf(dataArg) === 'object'); Ember.assert("You must include an `id` for " + modelNameArg + " in an object passed to `push`", dataArg.id != null && dataArg.id !== ''); data = _normalizeSerializerPayload(this.modelFor(modelNameArg), dataArg); modelName = modelNameArg; - Ember.deprecate('store.push(type, data) has been deprecated. Please provide a JSON-API document object as the first and only argument to store.push.'); Ember.assert('Passing classes to store methods has been removed. Please pass a dasherized string instead of '+ Ember.inspect(modelName), typeof modelName === 'string' || typeof data === 'undefined'); }