From 3bbc43177505c238404f5843cdc2f97dc1c15c66 Mon Sep 17 00:00:00 2001 From: Gaurav Munjal Date: Thu, 28 Nov 2019 07:26:08 -0500 Subject: [PATCH] fixes --- .../model/addon/-private/system/promise-many-array.js | 1 + packages/model/addon/index.ts | 2 +- .../store/addon/-private/system/model/internal-model.ts | 8 +++++--- packages/store/index.js | 8 +------- 4 files changed, 8 insertions(+), 11 deletions(-) diff --git a/packages/model/addon/-private/system/promise-many-array.js b/packages/model/addon/-private/system/promise-many-array.js index 86a9dc6dbc2..fd17103855b 100644 --- a/packages/model/addon/-private/system/promise-many-array.js +++ b/packages/model/addon/-private/system/promise-many-array.js @@ -24,6 +24,7 @@ import { PromiseArray, proxyToContent } from '@ember-data/store/-private'; @class PromiseManyArray @extends Ember.ArrayProxy + @private */ const PromiseManyArray = PromiseArray.extend({ links: FULL_LINKS_ON_RELATIONSHIPS ? reads('content.links') : undefined, diff --git a/packages/model/addon/index.ts b/packages/model/addon/index.ts index acb84d5e0ea..2bad2cbc4ac 100644 --- a/packages/model/addon/index.ts +++ b/packages/model/addon/index.ts @@ -39,4 +39,4 @@ @public */ -export { Model as default, attr, belongsTo, hasMany, ManyArray, PromiseManyArray } from './-private'; +export { Model as default, attr, belongsTo, hasMany } from './-private'; diff --git a/packages/store/addon/-private/system/model/internal-model.ts b/packages/store/addon/-private/system/model/internal-model.ts index 0e80a6a2b9e..1d95301aaef 100644 --- a/packages/store/addon/-private/system/model/internal-model.ts +++ b/packages/store/addon/-private/system/model/internal-model.ts @@ -43,8 +43,8 @@ type Relationships = import('@ember-data/record-data/-private/relationships/stat // move to TS hacks module that we can delete when this is no longer a necessary recast type ManyArray = InstanceType; -type PromiseBelongsTo = InstanceType; -type PromiseManyArray = InstanceType; +type PromiseBelongsTo = InstanceType; +type PromiseManyArray = InstanceType; /** @module @ember-data/store @@ -171,7 +171,9 @@ export default class InternalModel { error: any; constructor(public store: CoreStore | Store, public identifier: StableRecordIdentifier) { - _getModelPackage(); + if (HAS_MODEL_PACKAGE) { + _getModelPackage(); + } this._id = identifier.id; this.modelName = identifier.type; this.clientId = identifier.lid; diff --git a/packages/store/index.js b/packages/store/index.js index 51d4ab476ba..55a910a9bc4 100644 --- a/packages/store/index.js +++ b/packages/store/index.js @@ -7,12 +7,6 @@ const addonBaseConfig = addonBuildConfigForDataPackage(name); module.exports = Object.assign({}, addonBaseConfig, { shouldRollupPrivate: true, externalDependenciesForPrivateModule() { - return [ - '@ember-data/canary-features', - 'ember-inflector', - '@ember-data/store/-debug', - 'require', - '@ember-data/model', - ]; + return ['@ember-data/canary-features', 'ember-inflector', '@ember-data/store/-debug', 'require']; }, });