Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build currently fails due to invalid smoltcp branch #79

Closed
phil-opp opened this issue Feb 6, 2019 · 4 comments · Fixed by #80
Closed

Build currently fails due to invalid smoltcp branch #79

phil-opp opened this issue Feb 6, 2019 · 4 comments · Fixed by #80
Assignees

Comments

@phil-opp
Copy link
Contributor

phil-opp commented Feb 6, 2019

The pull request smoltcp-rs/smoltcp#186 was forced-pushed, so the commit referenced in the Cargo.lock does no longer exist. Updating the Cargo.lock is not possible at the moment because the new branch contains an invalid Cargo.toml: smoltcp-rs/smoltcp#186 (comment).

I think the best solution is to wait a bit and hope that the pull request gets merged soon. If it takes to long, we can use an own fork the branch to ensure that no force-pushes occur.

@zshipko
Copy link

zshipko commented Feb 20, 2019

How can I help with getting this to build? I would really like to be able to use it for an upcoming project!

@oli-obk
Copy link
Member

oli-obk commented Feb 21, 2019

I think just running cargo update should do the trick

@phil-opp
Copy link
Contributor Author

On the latest nightly the build still fails due to the updates to the futures/task API in rust-lang/rust#57992. I tried to rebase our futures-rs fork for these changes: https://github.com/embed-rs/futures-rs/tree/alloc-rebase (I used a separate branch because I didn't test it yet). We also need to update our core wrapper and the future_mutex and task_runtime modules.

@oli-obk oli-obk self-assigned this Feb 22, 2019
@oli-obk
Copy link
Member

oli-obk commented Feb 22, 2019

I'm gonna finish the rebases and updates

@oli-obk oli-obk mentioned this issue Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants