Unable to run dap-java-debug-test-* functions

[SerialVelocity]

Hey,

I've recently updated dap-mode and all the dap-java-debug-* methods have stopped working.

Here's a stacktrace:

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  string-match("\\'[[:ascii:]]+\\'" nil)
  puny-encode-domain(nil)
  open-network-stream(nil nil nil nil :type plain)
  (if dap-server-path (make-process :name session-name :connection-type 'pipe :coding 'no-conversion :command dap-server-path :stderr (generate-new-buffer-name (concat "*" session-name " stderr*")) :noquery t) (open-network-stream session-name nil host port :type 'plain))
  (let* ((host (plist-get launch-args :host)) (dap-server-path (plist-get launch-args :dap-server-path)) (session-name (plist-get launch-args :name)) (port (plist-get launch-args :debugServer)) (proc (if dap-server-path (make-process :name session-name :connection-type 'pipe :coding 'no-conversion :command dap-server-path :stderr (generate-new-buffer-name (concat "*" session-name " stderr*")) :noquery t) (open-network-stream session-name nil host port :type 'plain))) (debug-session (make-dap--debug-session :launch-args launch-args :proc proc :name (plist-get launch-args :name) :workspace lsp--cur-workspace))) (set-process-sentinel proc (function (lambda (_process exit-str) (message "Debug session process exited with status: %s" exit-str) (dap--mark-session-as-terminated debug-session)))) (set-process-filter proc (dap--create-filter-function debug-session)) debug-session)
  dap--create-session((:type "java" :request "attach" :hostName "localhost" :port 33001 :wait-for-port t :program-to-start "java -Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=33001 -jar /my-personal/junit-runner/JUnitRunner.jar -cp $JUNIT_CLASS_PATH -m com.testclass#testmethod" :environment-variables (("JUNIT_CLASS_PATH" . "really long classpath")) :cwd "/cwd"))
  dap-start-debugging((:type "java" :request "attach" :hostName "localhost" :port 33001 :wait-for-port t :program-to-start "java -Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=33001 -jar /my-personal/junit-runner/JUnitRunner.jar -cp $JUNIT_CLASS_PATH -m com.testclass#testmethod" :environment-variables (("JUNIT_CLASS_PATH" . "really long classpath")) :cwd "/cwd"))
  dap-debug((:type "java" :request "attach" :hostName "localhost" :port 33001 :wait-for-port t :program-to-start "java -Xdebug -Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=33001 -jar /my-personal/junit-runner/JUnitRunner.jar -cp $JUNIT_CLASS_PATH -m com.testclass#testmethod" :environment-variables (("JUNIT_CLASS_PATH" . "really long classpath")) :cwd "/cwd"))
  dap-java-debug-test-method(33001)
  funcall-interactively(dap-java-debug-test-method 33001)
  call-interactively(dap-java-debug-test-method record nil)
  command-execute(dap-java-debug-test-method record)
  execute-extended-command(nil "dap-java-debug-test-method" nil)
  funcall-interactively(execute-extended-command nil "dap-java-debug-test-method" nil)
  call-interactively(execute-extended-command nil nil)
  command-execute(execute-extended-command)

I made sure to update dash to the latest version as well so it doesn't seem to be caused by that.

Is it because dap-java-debug-test-method never calls dap-java--populate-default-args?

Best,
SerialVelocity

[yyoncho]

I really have to make the tests green again, fixed with: c217371