Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcore Darkness Night vision potion issue #16

Open
Qazplm601 opened this issue Sep 6, 2017 · 5 comments
Open

Hardcore Darkness Night vision potion issue #16

Qazplm601 opened this issue Sep 6, 2017 · 5 comments

Comments

@Qazplm601
Copy link

(posted this on the Albedo github before I knew this was the updated version, whoops! seems the bug is still the same though.)
When using the hardcore darkness mod and Mirage, if you use a potion of Night vision, instead of being lit up normally, dark areas are lit up in a yellowish tint.

Screenshot of the issue:
https://i.imgur.com/36Pd7kD.png

EDIT: for some reason this only occurs in dark areas underground and underwater, it does not happen above ground at night, from my testing.

Thank you!

@kane-thornwyrd
Copy link

I second this ticket.

@unascribed
Copy link
Contributor

unascribed commented Sep 8, 2017

Didn't get a notification about this issue, sorry.

Not sure how Hardcore Darkness works; will need to look into it.

Also, Elucent's Albedo isn't dead, though I'm not sure how much he cares about compatibility with other mods.

@unascribed
Copy link
Contributor

unascribed commented Sep 8, 2017

Quick question, though. @falkreon has been doing some overhauls to the light shader recently; does this issue still manifest on a 2.0.2 build?

@falkreon
Copy link
Member

falkreon commented Sep 9, 2017

Interesting! That's not distance fog, that's changes to the vanilla lightmap. I'd love to know if having AlternativeNightSkyLight set to false fixes this, as it tampers with the blue values in the lightmap - The issue might even be present without Mirage/Albedo.

The other thing you could test is whether turning smooth lighting off forces the yellow into distinct per-block steps. That'd mean it's 100% a lightmap issue.

@Qazplm601
Copy link
Author

sorry, forgot about this. it is still an issue with the 2.0.2 build, AlternateNightSkyLight=false does not fix it, and it does seem to be affected by smooth lighting.

(without/with)
https://i.imgur.com/KXokjd1.png
https://i.imgur.com/uMp6TsN.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants