Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Merge Access Users Cannot View Specific Merge Conflicts in Pull Requests They Review #457

Closed
monilpat opened this issue Nov 20, 2024 · 3 comments
Labels
bug Something isn't working no-issue-activity

Comments

@monilpat
Copy link
Collaborator

Describe the bug

Users without merge access are unable to view specific merge conflicts in pull requests. This limitation prevents them from resolving or contributing to conflict resolution effectively, as they cannot see the conflicting files or lines of code.

To Reproduce

  1. Create a pull request with merge conflicts.
  2. Ensure that the user reviewing the PR does not have merge access.
  3. Attempt to view the specific merge conflicts as the non-merge access user.

Expected behavior

Users without merge access should be able to view the specific merge conflicts within the pull request, including the files and lines of code in conflict, to assist in resolving the issue.

Screenshots

Additional context

This limitation may hinder collaboration and delay the resolution of merge conflicts, especially in teams where code reviews and conflict resolutions involve contributors without merge privileges.

@monilpat monilpat added the bug Something isn't working label Nov 20, 2024
@sirkitree
Copy link
Collaborator

Any suggestions on how to fix this? Is there a permission or something in gh we can update?

@monilpat
Copy link
Collaborator Author

Yeah for sure there has to be some settings in the actions yaml files that configures this, will have a look, just wanted to flag that either way a maintainer will need to address this! Thanks so much!

Copy link
Contributor

This issue has been automatically marked as stale due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity
Projects
None yet
Development

No branches or pull requests

3 participants
@sirkitree @monilpat and others