We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I would like to handle some connect errors, that are returned from :gun in specific way.
:gun
Is there any reason why the error is converted to string?
grpc/lib/grpc/adapter/gun.ex
Lines 68 to 71 in d8a58cc
Would it be okay to return just {:error, reason} instead of creating String error message?
{:error, reason}
Otherwise, for compatibility reasons, can another option be added to GRPC.Adapter.Gun.connect/2, that will prevent from converting error into String?
The text was updated successfully, but these errors were encountered:
String is to keep consistent with {:error, "Error when opening connection: protocol #{proto} is not http2"}. Let me change this.
{:error, "Error when opening connection: protocol #{proto} is not http2"}
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
I would like to handle some connect errors, that are returned from
:gun
in specific way.Is there any reason why the error is converted to string?
grpc/lib/grpc/adapter/gun.ex
Lines 68 to 71 in d8a58cc
Would it be okay to return just
{:error, reason}
instead of creating String error message?Otherwise, for compatibility reasons, can another option be added to GRPC.Adapter.Gun.connect/2, that will prevent from converting error into String?
The text was updated successfully, but these errors were encountered: