-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the navigation bar UI #1417
Comments
See @Shubham-Vishwakarma's UI suggestion at #1362 (comment) |
@nya-elimu can I work on this? |
@alexander-kuruvilla Yes, please 👍🏽 |
@nya-elimu thanks. As this is a design change I need your input on a few things,
|
@alexander-kuruvilla Yes, or consider using the |
@alexander-kuruvilla I think we can move it to the side panel for smaller screens 👍🏽 |
@alexander-kuruvilla I see what you mean. The seems to happen when the "Sign on" link disappears. So as a solution, I suggest moving the "Connect Wallet" button into the sidebar for smaller screens. Because then there will always be content in the sidebar. |
@nya-elimu I have done the aforementioned changes. Additionally I noticed that the breadcrumb overflows out into the content in smaller screens, when the breadcrumb has a lot of elements in it. |
@alexander-kuruvilla Thank you for implementing this improvement 🙂 I did a quick test at http://hin.elimu.ai, and it looks like there is one final adjustment that needs to be made for the scenario where a content creator is signed in, and on a small screen, and already connected to a Web3 wallet: In the case where a content creator has already connected a Web3 wallet, the button should change from "Connect Wallet" to showing the same information as in the wide screen example above. |
@jo-elimu Thanks for pointing that out I'll make the changes as soon as I can. I would also like to know your opinion on the breadcrumbs on smaller screens. When in inner pages the breadcrumbs seem to overflow into the content div |
@alexander-kuruvilla Thanks for fixing the button in the side drawer. One final detail: When connected loading the token balance, it works in a small screen, but not on a wide screen: Small ScreenWide ScreenMy guess would be that this is happening because both buttons have the same |
Yes I think you are right. I'll take a look at how that can be resolved. |
@alexander-kuruvilla It works now, thank you 🙂 |
@jo-elimu nice! Thanks! |
When there is more content in the navigation bar, the content sometimes overflows. Improve the UX/UI so that the navigation and its content works with a variety of text lengths and screen sizes.
For an example see #1362 (comment), reported by @cravend.
The text was updated successfully, but these errors were encountered: