Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the navigation bar UI #1417

Closed
nya-elimu opened this issue Aug 29, 2021 · 14 comments · Fixed by #1883
Closed

Improve the navigation bar UI #1417

nya-elimu opened this issue Aug 29, 2021 · 14 comments · Fixed by #1883
Assignees
Labels
good first issue Good for newcomers ux/ui User Experience (UX) / User Interface (UI)

Comments

@nya-elimu
Copy link
Member

nya-elimu commented Aug 29, 2021

When there is more content in the navigation bar, the content sometimes overflows. Improve the UX/UI so that the navigation and its content works with a variety of text lengths and screen sizes.

For an example see #1362 (comment), reported by @cravend.

@nya-elimu nya-elimu added ux/ui User Experience (UX) / User Interface (UI) good first issue Good for newcomers labels Aug 29, 2021
@nya-elimu
Copy link
Member Author

See @Shubham-Vishwakarma's UI suggestion at #1362 (comment)

@alexander-kuruvilla
Copy link
Contributor

@nya-elimu can I work on this?
From the current Ui I can seen that the "connect wallet" overflows and jumps out in smaller screens and the contributer name /email also jumps out.

image

@nya-elimu
Copy link
Member Author

@alexander-kuruvilla Yes, please 👍🏽

@alexander-kuruvilla
Copy link
Contributor

alexander-kuruvilla commented Aug 10, 2024

@nya-elimu thanks. As this is a design change I need your input on a few things,

  1. Should I change the the profile to display just the first name of the contributor as per Shubham's suggestion?

  2. Should the connect account be removed or moved inside the side panel for smaller screens? Or another solution is to ditch the text in smaller screens like shown below:
    image

  3. The side panel menu toggle seems to appear in smaller screens, but in the /webapp page clicking on it just dims the page and doesnt seems to bring up a menu. What is your suggestion on that?:
    image

@nya-elimu
Copy link
Member Author

  1. Should I change the the profile to display just the first name of the contributor as per Shubham's suggestion?

@alexander-kuruvilla Yes, or consider using the text-overflow property in CSS.

@nya-elimu
Copy link
Member Author

2. Should the connect account be removed or moved inside the side panel for smaller screens? Or another solution is to ditch the text in smaller screens like shown below:
image

@alexander-kuruvilla I think we can move it to the side panel for smaller screens 👍🏽

@nya-elimu
Copy link
Member Author

3. The side panel menu toggle seems to appear in smaller screens, but in the /webapp page clicking on it just dims the page and doesnt seems to bring up a menu. What is your suggestion on that?:
image

@alexander-kuruvilla I see what you mean.

The seems to happen when the "Sign on" link disappears. So as a solution, I suggest moving the "Connect Wallet" button into the sidebar for smaller screens. Because then there will always be content in the sidebar.

@alexander-kuruvilla
Copy link
Contributor

@nya-elimu I have done the aforementioned changes. Additionally I noticed that the breadcrumb overflows out into the content in smaller screens, when the breadcrumb has a lot of elements in it.

@jo-elimu
Copy link
Member

@alexander-kuruvilla Thank you for implementing this improvement 🙂

I did a quick test at http://hin.elimu.ai, and it looks like there is one final adjustment that needs to be made for the scenario where a content creator is signed in, and on a small screen, and already connected to a Web3 wallet:

In the case where a content creator has already connected a Web3 wallet, the button should change from "Connect Wallet" to showing the same information as in the wide screen example above.

@jo-elimu jo-elimu reopened this Sep 10, 2024
@alexander-kuruvilla
Copy link
Contributor

@jo-elimu Thanks for pointing that out I'll make the changes as soon as I can.

I would also like to know your opinion on the breadcrumbs on smaller screens. When in inner pages the breadcrumbs seem to overflow into the content div

@jo-elimu
Copy link
Member

@alexander-kuruvilla Thanks for fixing the button in the side drawer.

One final detail: When connected loading the token balance, it works in a small screen, but not on a wide screen:

Small Screen

Screenshot 2024-09-11 163611

Wide Screen

Screenshot 2024-09-11 163636

Screenshot 2024-09-11 163643

My guess would be that this is happening because both buttons have the same #tokenBalance ID, which should be unique per HTML element.

@alexander-kuruvilla
Copy link
Contributor

@alexander-kuruvilla Thanks for fixing the button in the side drawer.

One final detail: When connected loading the token balance, it works in a small screen, but not on a wide screen:

Small Screen

Screenshot 2024-09-11 163611

Wide Screen

Screenshot 2024-09-11 163636

Screenshot 2024-09-11 163643

My guess would be that this is happening because both buttons have the same #tokenBalance ID, which should be unique per HTML element.

Yes I think you are right. I'll take a look at how that can be resolved.

@jo-elimu
Copy link
Member

jo-elimu commented Sep 12, 2024

@alexander-kuruvilla It works now, thank you 🙂

@alexander-kuruvilla
Copy link
Contributor

@jo-elimu nice! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ux/ui User Experience (UX) / User Interface (UI)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants