Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Complement test Docker build times in CI #14316

Open
matrixbot opened this issue Dec 20, 2023 · 0 comments
Open

Enforce Complement test Docker build times in CI #14316

matrixbot opened this issue Dec 20, 2023 · 0 comments

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 20, 2023

This issue has been migrated from #14316.


As mentioned in the weekly backend team call and in the internal backend room


Testing with Complement has gotten so slow, matrix-org/synapse#13204

Before people put effort into making it faster again, it would be nice to add some CI to enforce that we don't regress the timing. We've fixed and regressed the timing many times so I think it's worth actually enforcing. And as @clokep describes it, "slow tooling really impacts velocity." :feelsgood:

What we want to test is that a rebuild after a Synapse source change is fast. Not concerned with initial build times here since that's not the primary dev experience when iterating on a feature/bug.

Potential solutions

Add a Complement Docker image rebuild job and fail the CI if it goes over a threshold duration.

It would be nice to do this as part of the existing Complement job since it has to do the initial Docker build there anyway.

@matrixbot matrixbot changed the title Dummy issue Enforce Complement test Docker build times in CI Dec 21, 2023
@matrixbot matrixbot reopened this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant