Escape eventIds in CS API requests

[manuroe]

@manuroe commented on Fri Feb 08 2019

Event IDs in room version 3 can now include hashes in them according to MSC1659.

APIs that must be checked:

/admin/purge_history/(?P<room_id>[^/]*)(/(?P<event_id>[^/]+))?
/events/(?P<event_id>[^/]*)$
/rooms/(?P<room_id>[^/]*)/report/(?P<event_id>[^/]*)$
/rooms/(?P<room_id>[^/]*)/event/(?P<event_id>[^/]*)$
/rooms/(?P<room_id>[^/]*)/context/(?P<event_id>[^/]*)$
/rooms/(?P<room_id>[^/]*)/redact/(?P<event_id>[^/]*)
/rooms/(?P<room_id>[^/]*)/receipt/(?P<receipt_type>[^/]*)/(?P<event_id>[^/]*)$

[ganfra]

By default Path parameters are already escaped by retrofit:
https://square.github.io/retrofit/2.x/retrofit/index.html?retrofit2/http/Path.html

[manuroe]

Because of #2947, could we double-check please?

On iOS, I ended to port the js encodeURIComponent to have the expected behavior.

Also, MXPatterns.isEventId() must support v3 event ids that looks like $pmOSN/DognfuSfhdW/qivXT19lfCWpdSfaPFKDBTJUk+ (iOS commit: matrix-org/matrix-ios-sdk@454a3fc?utf8=%E2%9C%93&diff=split&w=1)

[bmarty]

Double check done :)