Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we need a way to dismiss unsent messages prompt #891

Closed
AmandineLP opened this issue Feb 9, 2016 · 6 comments
Closed

we need a way to dismiss unsent messages prompt #891

AmandineLP opened this issue Feb 9, 2016 · 6 comments

Comments

@AmandineLP
Copy link
Contributor

a cross shown when hovering?

@AmandineLP AmandineLP added the P1 label Feb 9, 2016
@AmandineLP AmandineLP added this to the v1 - Private Preview milestone Feb 9, 2016
@ara4n ara4n added the feature label Feb 14, 2016
@ara4n
Copy link
Member

ara4n commented Mar 18, 2016

assigning to rich as he's been on an unsent message mission (and i don't want to collide with it)

@richvdh
Copy link
Member

richvdh commented Mar 21, 2016

Would the intention be to leave the unsent messages (in red) in the timeline? (In contrast to what happens when you 'Cancel sending' on a message, which removes it from the timeline)

If so, things get slightly trickier semantically:

  • What happens when another message fails (so the prompt comes back) and the user clicks 'send all'? Do we resend all failed messages, or just the ones that happened since the user dismissed the prompt?
  • What if the user changes room and comes back? Does the prompt reappear or stay hidden?

@richvdh
Copy link
Member

richvdh commented Mar 21, 2016

@AmandineLP: those questions mostly for you, I guess

@richvdh
Copy link
Member

richvdh commented Mar 21, 2016

  • yes we should leave the messages
  • when the prompt comes back and the user clicks it, we resend all failed messages
  • when the user changes room, the prompt stays dismissed

@AmandineLP
Copy link
Contributor Author

As discussed, let's just make the user choose between "resend all" and "remove all" and if they want to resend only part of the messages they send them individually and cancel all the others (or vice versa). It forces them to make a decision.

@richvdh
Copy link
Member

richvdh commented Mar 21, 2016

Done by matrix-org/matrix-react-sdk#238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants