Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notified on string that's a substring of my full displayname #6307

Closed
non-Jedi opened this issue Mar 13, 2018 · 3 comments
Closed

Notified on string that's a substring of my full displayname #6307

non-Jedi opened this issue Mar 13, 2018 · 3 comments
Labels
A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-GetYourUpdates

Comments

@non-Jedi
Copy link

Description

My displayname is "&Adam". My mxid is "@adam:thebeckmeyers.xyz". I receive notifications when someone includes the string "Adam" in their message body despite not having set it up as a keyword. My notification settings look like this:

riot_notification_settings

and my keywords look like this:

riot_notification_keywords

I see no reason I should be notified on the string "Adam".

Steps to reproduce

See above.

Version information

  • Platform: web (in-browser)
  • Browser: Chrome (ish)
  • OS: Void Linux
  • URL: riot.im/develop
@non-Jedi non-Jedi changed the title Notified for on string that's a substring of my full displayname Notified on string that's a substring of my full displayname Mar 13, 2018
@non-Jedi
Copy link
Author

non-Jedi commented Mar 13, 2018 •
edited
Loading

Potentially related synapse bug: matrix-org/synapse#2172 . I think I'm seeing the same behavior with my current displayname.

Nevermind. This one is strictly a Riot-side issue. I get "notified" on "Adam", but it doesn't show up on a request to /_matrix/client/r0/notifications. I'm assuming Riot is doing something to generate notifications (green or red blobs with numbers in them) outside of calling that endpoint?

@lampholder lampholder added T-Defect P1 S-Minor Impairs non-critical functionality or suitable workarounds exist A-Notifications P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed S-Minor Impairs non-critical functionality or suitable workarounds exist P1 labels Mar 13, 2018
@ShadowJonathan
Copy link
Contributor

I'm currently working on something like this with MSC3517

@SimonBrandner SimonBrandner added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed P2 labels Jan 20, 2022
@novocaine novocaine added S-Minor Impairs non-critical functionality or suitable workarounds exist and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Feb 21, 2022
@daniellekirkwood daniellekirkwood mentioned this issue Dec 23, 2022
Closed
2 tasks
@clokep
Copy link

clokep commented Sep 26, 2023

This should be solved by MSC3952, which is available in Element Web, but might take some time to rollout to the entire ecosystem.

@clokep clokep closed this as completed Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-GetYourUpdates
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@novocaine @clokep @lampholder @non-Jedi @ShadowJonathan @SimonBrandner @daniellekirkwood