Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: old Rich Replies bug causes react-gemini-scrollbar to somehow lose its reference to its scrollbar and NPEing #6089

Closed
ara4n opened this issue Feb 5, 2018 · 2 comments
Labels
P1 S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Regression

Comments

@ara4n
Copy link
Member

ara4n commented Feb 5, 2018

I'm going to guess this is somehow related to #6068, but for the last few times i've unslept my laptop, I've had the app completely frozen and crashes like:

Switching to room id !fILrmqIZQfJcrUiBRk:matrix.org at event undefined
10:07:18.868 bundle.js:12677 Uncaught TypeError: Cannot read property 'update' of null
    at Object.componentDidUpdate (bundle.js:12677)
    at measureLifeCyclePerf (bundle.js:309331)
    at bundle.js:309984
    at CallbackQueue.notifyAll (bundle.js:118670)
    at ReactReconcileTransaction.close (bundle.js:314359)

in the log. In practice, bundle.js:12677 is:

	    componentDidUpdate: function componentDidUpdate() {
	        this.scrollbar.update();
	    },

...within react-gemini-scrollbar.

Will rageshake.

@ara4n ara4n added T-Defect P1 X-Regression S-Critical Prevents work, causes data loss and/or has no workaround labels Feb 5, 2018
@turt2live
Copy link
Member

Fwiw, I've only seen this when a rich quote crashes the app.

@ara4n ara4n changed the title regression: react-gemini-scrollbar is somehow losing its reference to its scrollbar and NPEing regression: old Rich Replies bug causes react-gemini-scrollbar to somehow lose its reference to its scrollbar and NPEing Feb 12, 2018
@lukebarnard1
Copy link
Contributor

Closing because this only affects the old rich replies feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Regression
Projects
None yet
Development

No branches or pull requests

3 participants