Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing a markdown message removes all horizontal lines #19248

Closed
puenka opened this issue Oct 1, 2021 · 2 comments
Closed

Editing a markdown message removes all horizontal lines #19248

puenka opened this issue Oct 1, 2021 · 2 comments
Labels
A-Composer A-Message-Editing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@puenka
Copy link

puenka commented Oct 1, 2021

Steps to reproduce

  1. Write a markdown message with a horizontal line to a recipient like:
# Hello!
- - -
This is a message from me to you!
- - -
  1. Click on Edit to modify the message.

What happened?

What did you expect?

I expected to see the original markdown source of the message.

What happened?

The lines containing horizontal lines disappeared. In the example above, the edit text field shows

# Hello!
This is a message from me to you!

Operating system

Ubuntu 20.04

Application version

Element version: 1.9.0 Olm version: 3.2.3

How did you install the app?

Flatpak

Homeserver

matrix.org

Have you submitted a rageshake?

No
@puenka puenka added the T-Defect label Oct 1, 2021
@SimonBrandner SimonBrandner added A-Composer Z-Upstream O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist labels Oct 1, 2021
@aaronraimist
Copy link
Collaborator

@SimonBrandner I doubt this is an upstream issue. The fix should be something similar to https://github.com/matrix-org/matrix-react-sdk/pull/3030/files.

@robintown
Copy link
Member

Fixed by matrix-org/matrix-react-sdk#7543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Composer A-Message-Editing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@puenka @aaronraimist @SimonBrandner @robintown