Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop notifs prompt doesn't disappear when you click enable #1095

Closed
matrixbot opened this issue Mar 4, 2016 · 4 comments
Closed

Desktop notifs prompt doesn't disappear when you click enable #1095

matrixbot opened this issue Mar 4, 2016 · 4 comments
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Milestone
v1 - Private Preview

Comments

@matrixbot
Copy link

Created by @ dave:matrix.org.
@mebjas
Copy link

mebjas commented Mar 5, 2016

Should the prompt hide when notification is enabled by dialog raised by the browser or as soon as user clicks on enable ?

@mebjas
Copy link

mebjas commented Mar 5, 2016

Also, if a user decide to close the prompt, that should be persistent, the prompt comes back on reload

This was referenced Mar 5, 2016
Closed
Closed
@ara4n
Copy link
Member

ara4n commented Mar 6, 2016

@mebjas: see feedback on this and #951 in the comments on #1111

@ara4n ara4n added T-Defect P2 S-Minor Impairs non-critical functionality or suitable workarounds exist labels Mar 6, 2016
@ara4n ara4n added this to the v1 - Private Preview milestone Mar 6, 2016
@ara4n ara4n mentioned this issue Mar 19, 2016
Closed
@richvdh richvdh mentioned this issue Mar 22, 2016
Merged
@richvdh
Copy link
Member

richvdh commented Mar 29, 2016

Fixed in matrix-org/matrix-react-sdk#240, thanks to @mebjas

@richvdh richvdh closed this as completed Mar 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
v1 - Private Preview
Development

No branches or pull requests
4 participants
@ara4n @richvdh @mebjas @matrixbot