Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Configure - "if options.run_gyp:" should be "if not options.run_gyp" #90

Open
tmcdos opened this issue Dec 21, 2018 · 0 comments
Open

Comments

@tmcdos
Copy link

tmcdos commented Dec 21, 2018

I am using Windows on my PC and I have an unrelated issue with the bundled Node so I have to patch one of the Node's internal JS modules (and hence must recompile node.dll)

When I tried to build electron-node-10.2.0 I got the error Failed to create vc project files.

After some primitive debugging I think that the reason for this error lies on the last line in configure. Instead of

if options.run_gyp:
  run_gyp(gyp_args)

it should be

if not options.run_gyp:
  run_gyp(gyp_args)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant