[Feature Request] Environment Variables to adjust CORS header values

[aleccool213]

Feature Request

I have read the docs concerning the CORS header values and how to configure them using a reverse proxy. For myself, my need for a reverse proxy is low, I am requesting the ability to add these headers to all requests when new environment variables are added and set.

For e.g.

res.addHeader("Access-Control-Allow-Origin", "https://myackeehostedinstance.herokuapp.com")

[electerious]

Hey @aleccool213, the reverse proxy is required for both HTTPS and CORS. My plan was to keep the server related logic away from Ackee as everyone has a different setup.

How are you adding HTTPS?

[aleccool213]

My plan was to keep the server related logic away from Ackee as everyone has a different setup.

This is a smart separation of concerns and I generally agree with this.

Unfortunately for me, I am running Ackee on Heroku. It provides a free SSL certificate for free dynos.

Albeit, not a strict cert for my specific domain.

I could spend some time getting NGNIX set up on Heroku, from my initial research it looks like a lot of people have done this.

Ideally, to keep the amount of config low for newcomers, they wouldn't need to do this. Or we should at least reference to an example for others to use: https://github.com/narr/heroku-nginx-node-example

[aleccool213]

Update on this, I tried getting https://github.com/narr/heroku-nginx-node-example up and running but it is super old. Need more time to debug why that wasn't working, or try it from scratch myself.

[electerious]

Will be part of v1.4.3.

[electerious]

Should ACKEE_ALLOW_ORIGIN be part of the app.json so it can be configured by the user?