Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Change Proposal] Resolve use of unspecified fields in the integrations packages field description files #271

Open
efd6 opened this issue Feb 8, 2022 · 1 comment
Labels
discuss Issue needs discussion

Comments

@efd6
Copy link
Contributor

efd6 commented Feb 8, 2022

During work on an ECS and pipeline description analysis tool I found that a variety of fields used in integration package field descriptions are not specified. After discussion with @andrewkroh on what to do with these we decided to file this catch-all issue for either letting teams remove the fields and/or for people to have a discussion here to resolve the specification of the fields.

The list is long so it is available at this gist.

The code used to generate the list is here. The output can be regenerated for any commit by checking out the commit and running the code in the packages directory of the github.com/elastic/integrations repo.

@efd6 efd6 added the discuss Issue needs discussion label Feb 8, 2022
@andrewkroh
Copy link
Member

andrewkroh commented Feb 8, 2022

My proposal is to enhance the package-spec definition for the fields.yml files with the properties that Fleet EPM actually uses. Those can be found at:

https://github.com/elastic/kibana/blob/b4b3285643dd9105e4c34883e8c032e771ee5fcb/x-pack/plugins/fleet/server/services/epm/fields/field.ts#L14-L59

Of the properties that are already declared, title and dimension are unused. dimension is new in #236 so I assume support will be added to EPM soon. But I'm not sure where title is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs discussion
Projects
None yet
Development

No branches or pull requests

2 participants