Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete batch files from deb (and rpm) packages #2844

Open
Mister-X- opened this issue Mar 18, 2015 · 2 comments
Open

Delete batch files from deb (and rpm) packages #2844

Mister-X- opened this issue Mar 18, 2015 · 2 comments
Labels
bug good first issue hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact" packaging

Comments

@Mister-X-
Copy link

I noticed on my Linux system, when using the package that it is also installing .bat files (for Windows) along with the bash scripts to run the script.

Here is a patch that should take care of removing them before building the package (untested):

diff --git a/pkg/build.sh b/pkg/build.sh
index 8ad876b..0d56ab4 100755
--- a/pkg/build.sh
+++ b/pkg/build.sh
@@ -41,6 +41,9 @@ fi

 tar -C $destdir/$prefix --strip-components 1 -zxpf $tar

+# Delete batch files
+rm -f $destdir/opt/logstash/bin/*.bat
+
 case $os@$release in
  centos@*|fedora@*|el6@*|sl6@*)
     mkdir -p $destdir/etc/logrotate.d
@jordansissel
Copy link
Contributor

Sorry, I've been meaning to purge the pkg/ directory of unused things. We dont' use pkg/build.sh anymore.

The code for this is in rakelib/artifacts.rake, I think

@suyograo suyograo added this to the v1.5.0 milestone Mar 18, 2015
@suyograo suyograo modified the milestones: v1.5.0, v1.5.1 Mar 19, 2015
@suyograo suyograo added v1.5.1 and removed v1.5.0 labels May 26, 2015
@suyograo suyograo removed this from the v1.5.1 milestone May 26, 2015
@suyograo suyograo added v1.6.0 and removed v1.5.1 labels May 28, 2015
@suyograo suyograo removed the v1.6.0 label Sep 25, 2015
@jordansissel
Copy link
Contributor

jordansissel commented Apr 28, 2017

Checked on this tonight to confirm if it is still occurring, and it is:

% rpm2cpio logstash-5.3.2.rpm | cpio -it | grep usr/share/logstash/bin/.*bat
./usr/share/logstash/bin/logstash-plugin.bat
./usr/share/logstash/bin/logstash.bat
./usr/share/logstash/bin/setup.bat

@jsvd jsvd added hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact" and removed hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact" labels Oct 1, 2018
@danhermann danhermann added the hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact" label Oct 1, 2018
@jordansissel jordansissel removed their assignment Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue hacktoberfest "Everyone is welcome, Quantity is fun, quality is key, Short term actions, long term impact" packaging
Projects
None yet
Development

No branches or pull requests

6 participants