Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts and cases page components for observability plugin #93365

Merged
merged 16 commits into from
Mar 23, 2021

Conversation

smith
Copy link
Contributor

@smith smith commented Mar 3, 2021

Set up the scaffolding for alerts and cases in observability, as the initial work for elastic/security-team#901.

Examples of components are in Storybook: https://ci-artifacts.kibana.dev/storybooks/pr-93365/a17c29925a56ee6536ba15d2a467b00f0196f542/observability/iframe.html?id=app-alerts--example&viewMode=story

There's a feature flag in Kibana advanced settings under Observability:

image

When this is enabled the Alerts and Cases are available in the top-level navigation:

image

The link to "Manage alerts" in the overview goes to the new alerts page when the feature flag is enabled:

image

The alerts page shows the search bar (which is not functional) and placeholder alerts table with sample data based on the wireframes:

image

You can click on "Alert details" in a row to show the flyout:

image

The first item has some example data included to fill out an example in the flyout.

The "Manage detection rules" button links to the Kibana alert settings (once we have our own page for managing rules in a future milestone we'll link there.)

The cases page is empty and shows a disclaimer:

image

The "Manage alerts"/"View active alerts" items on the header menu alerts dropdown in APM, Logs, Metrics, and Uptime have not been changed and still go to the Stack Management Alerts and Actions page:

image

There's currently a console error that happens:

query_string_input.tsx:101 Uncaught (in promise) TypeError: this.services.data.autocomplete.hasQuerySuggestions is not a function

I believe this is due to the search bar not being properly set up at this time and can be safely ignored.

Create components for the alerts and cases pages. This only contains basic empty components and stories for them.
@smith smith added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.13.0 Project:ObservabilityOfAlerting Alerting team project for observability of alerting. auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 3, 2021
@smith smith added Team:Observability Team label for Observability Team (for things that are handled across all of observability) Theme: rac label obsolete and removed Project:ObservabilityOfAlerting Alerting team project for observability of alerting. labels Mar 4, 2021
@smith
Copy link
Contributor Author

smith commented Mar 4, 2021

retest

@smith smith marked this pull request as draft March 7, 2021 01:21
@smith
Copy link
Contributor Author

smith commented Mar 7, 2021

Putting this back in draft. I'll add the routes in observability and have this set up to be ready to receive the table and other components from #93873.

@smith smith marked this pull request as ready for review March 11, 2021 20:40
@smith smith requested review from a team as code owners March 12, 2021 01:37
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry changes LGTM!

@spong
Copy link
Member

spong commented Mar 19, 2021

@elasticmachine merge upstream

@smith
Copy link
Contributor Author

smith commented Mar 22, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 99 107 +8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 178.1KB 190.4KB +12.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 24.7KB 25.2KB +515.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻

@smith smith merged commit 5e31f91 into elastic:master Mar 23, 2021
@smith smith deleted the nls/rac-pages branch March 23, 2021 12:58
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 23, 2021
)

Create components for the alerts and cases pages. This only contains basic empty components and stories for them.
@kibanamachine
Copy link
Contributor

💚 Backport successful

7.x / #95155

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 23, 2021
…95155)

Create components for the alerts and cases pages. This only contains basic empty components and stories for them.

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Observability Team label for Observability Team (for things that are handled across all of observability) Theme: rac label obsolete v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants