Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Security Solutions] Fixes Cypress tests for indicator match by making the selectors more specific (#91947) #91974

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

spong
Copy link
Member

@spong spong commented Feb 19, 2021

Backports the following commits to 7.x:

…g the selectors more specific (elastic#91947)

## Summary

Fixes the indicator match rules cypress e2e tests by making the selectors more specific. Previously other rules and forms code which live on the DOM beside the indicator match rules could interfere when moving around on the DOM. Now with more specific selectors this should be less likely to happen.

If it does happen again I will make the selectors even more specific. 

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@spong spong added the backport label Feb 19, 2021
@spong spong enabled auto-merge (squash) February 19, 2021 06:09
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spong spong merged commit 0abc92a into elastic:7.x Feb 19, 2021
@spong spong deleted the backport/7.x/pr-91947 branch February 19, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants