Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solutions] Fixes Cypress tests for indicator match by making the selectors more specific #91947

Merged
merged 3 commits into from
Feb 19, 2021
Merged

[Security Solutions] Fixes Cypress tests for indicator match by making the selectors more specific #91947

merged 3 commits into from
Feb 19, 2021

Conversation

FrankHassanabad
Copy link
Contributor

@FrankHassanabad FrankHassanabad commented Feb 18, 2021 •
edited
Loading

Summary

Fixes the indicator match rules cypress e2e tests by making the selectors more specific. Previously other rules and forms code which live on the DOM beside the indicator match rules could interfere when moving around on the DOM. Now with more specific selectors this should be less likely to happen.

If it does happen again I will make the selectors even more specific.

Checklist

@FrankHassanabad FrankHassanabad changed the title Fixes Cypress tests for indicator match [Security Solutions] Fixes Cypress tests for indicator match by making the selectors more specific Feb 18, 2021
@FrankHassanabad FrankHassanabad self-assigned this Feb 18, 2021
@FrankHassanabad FrankHassanabad added v8.0.0 v7.12.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Indicator Match Rule Security Solution Indicator Match rule type Team:Detections and Resp Security Detection Response Team labels Feb 18, 2021
@FrankHassanabad FrankHassanabad marked this pull request as ready for review February 18, 2021 22:38
@FrankHassanabad FrankHassanabad requested a review from a team as a code owner February 18, 2021 22:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@FrankHassanabad FrankHassanabad added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 18, 2021
spong
spong approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@spong spong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks for the quick turn around on keeping our test coverage up! 🙃

@spong spong enabled auto-merge (squash) February 18, 2021 22:54
@FrankHassanabad
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @FrankHassanabad

@spong spong merged commit 8d9ac00 into elastic:master Feb 19, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 19, 2021
@FrankHassanabad @kibanamachine
[Security Solutions] Fixes Cypress tests for indicator match by makin…
0cce04c 
…g the selectors more specific (elastic#91947)

## Summary

Fixes the indicator match rules cypress e2e tests by making the selectors more specific. Previously other rules and forms code which live on the DOM beside the indicator match rules could interfere when moving around on the DOM. Now with more specific selectors this should be less likely to happen.

If it does happen again I will make the selectors even more specific. 

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@kibanamachine kibanamachine mentioned this pull request Feb 19, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.12 / #91971

Successful backport PRs will be merged automatically after passing CI.

@spong spong added the v7.13.0 label Feb 19, 2021
@spong spong mentioned this pull request Feb 19, 2021
Merged
spong pushed a commit to spong/kibana that referenced this pull request Feb 19, 2021
@FrankHassanabad @spong
[Security Solutions] Fixes Cypress tests for indicator match by makin…
d3d153c 
…g the selectors more specific (elastic#91947)

## Summary

Fixes the indicator match rules cypress e2e tests by making the selectors more specific. Previously other rules and forms code which live on the DOM beside the indicator match rules could interfere when moving around on the DOM. Now with more specific selectors this should be less likely to happen.

If it does happen again I will make the selectors even more specific. 

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine added a commit that referenced this pull request Feb 19, 2021
@kibanamachine @FrankHassanabad
[Security Solutions] Fixes Cypress tests for indicator match by makin…
b22a59a 
…g the selectors more specific (#91947) (#91971)

## Summary

Fixes the indicator match rules cypress e2e tests by making the selectors more specific. Previously other rules and forms code which live on the DOM beside the indicator match rules could interfere when moving around on the DOM. Now with more specific selectors this should be less likely to happen.

If it does happen again I will make the selectors even more specific. 

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
spong added a commit that referenced this pull request Feb 19, 2021
@spong @FrankHassanabad
[Security Solutions] Fixes Cypress tests for indicator match by makin…
0abc92a 
…g the selectors more specific (#91947) (#91974)

## Summary

Fixes the indicator match rules cypress e2e tests by making the selectors more specific. Previously other rules and forms code which live on the DOM beside the indicator match rules could interfere when moving around on the DOM. Now with more specific selectors this should be less likely to happen.

If it does happen again I will make the selectors even more specific. 

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 19, 2021
@gmmorris
Merge branch 'master' into task-manager/docs-monitoring
fa807e9 
* master: (111 commits)
  [Logs UI] Replace dependencies in the infra bundle (elastic#91503)
  [Search Source] Do not request unmapped fields if source filters are provided (elastic#91921)
  [APM] Kql Search Bar suggests values outside the selected time range (elastic#91918)
  Refactored component edit policy tests into separate folders and using client integration testing setup (elastic#91657)
  [Fleet] Don't error on missing package_assets value (elastic#91744)
  [Lens] Pass used histogram interval to chart (elastic#91370)
  [Indexpattern management] Use indexPatterns Service instead of savedObjects client (elastic#91839)
  [Security Solutions] Fixes Cypress tests for indicator match by making the selectors more specific (elastic#91947)
  [CI] backportrc can skip CI (elastic#91886)
  Revert "[SOM] fix flaky suites (elastic#91809)"
  [Fleet] Install Elastic Agent integration by default during setup (elastic#91676)
  [Fleet] Silently swallow 404 errors when deleting ingest pipelines (elastic#91778)
  [data.search] Use incrementCounter for search telemetry (elastic#91230)
  [Fleet] Bootstrap functional test suite (elastic#91898)
  [Alerts][Docs] Added API documentation for alerts plugin (elastic#91067)
  Use correct environment in anomaly detection setup link (elastic#91877)
  [FTSR] Convert to tasks and add jest/api integration suites (elastic#91770)
  [CI] Build and publish storybooks (elastic#87701)
  docs: add PHP agent info to docs (elastic#91773)
  [DOCS] Adds and updates Visualization advanced settings (elastic#91904)
  ...
@FrankHassanabad FrankHassanabad deleted the fix-indicator-match-cypress-test branch February 19, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madirey madirey madirey approved these changes

@spong spong spong approved these changes

Assignees

@FrankHassanabad FrankHassanabad

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Indicator Match Rule Security Solution Indicator Match rule type release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team v7.12.0 v7.13.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FrankHassanabad @elasticmachine @kibanamachine @madirey @spong