Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip and Fix maps x-pack functional test - ( sample data and layer_errors) and also added baseline images #91205

Merged
merged 19 commits into from
Feb 11, 2021
Merged

Unskip and Fix maps x-pack functional test - ( sample data and layer_errors) and also added baseline images #91205

merged 19 commits into from
Feb 11, 2021

Conversation

rashmivkulkarni
Copy link
Contributor

Ref: #90323

@rashmivkulkarni
fixes elastic#74449
f3fc995
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana
411da9a
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana
154ce17
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana
a1783d8
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana
04de479
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana
cd06932
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana
50550f6
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana
ee59795
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana
2707fa3
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana
645d38c
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana
f2e4413
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana
c8997f4
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana
98e4c1a
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana
ce6e07e
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana
82ca014
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana
9db2869
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana
41a7a52
@rashmivkulkarni
Merge branch 'master' of github.com:elastic/kibana into maps_unskip
a5c64b7
@rashmivkulkarni
unskip maps tests (elastic#90323)
8211da3 
* unskip maps tests

* checking the baseline images

* updated the test to move the mouse away and close the Legend

* more changes to the test

* reducing the threshold limit

* updating the baseline images

* added a comment about the baseline images

* updating flights baseline image and adjusting threshold

* updated threshold and baseline image for web log

* session image of weblogsmap

* skipping layer_errors test

* skip the test - as it fails on cloud and windows on snapshot
@rashmivkulkarni rashmivkulkarni requested a review from a team as a code owner February 11, 2021 20:02
@rashmivkulkarni rashmivkulkarni added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.12.0 labels Feb 11, 2021
@rashmivkulkarni rashmivkulkarni self-assigned this Feb 11, 2021
@rashmivkulkarni rashmivkulkarni added the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Feb 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.6MB 2.6MB +14.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

LeeDr
LeeDr approved these changes Feb 11, 2021
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this was a forward port of the fix from 7.11

@rashmivkulkarni rashmivkulkarni enabled auto-merge (squash) February 11, 2021 22:36
kindsun
kindsun approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the skipped tests! My only comment would be that the .02 tolerance range for image comparisons feels pretty tight compared to the old ones, but on that I defer to the QA experts 🙇

  • code review

@rashmivkulkarni rashmivkulkarni merged commit a96aa5e into elastic:master Feb 11, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 15, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 91205 or prevent reminders by adding the backport:skip label.

3 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 91205 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 91205 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 91205 or prevent reminders by adding the backport:skip label.

@rashmivkulkarni rashmivkulkarni mentioned this pull request Feb 19, 2021
Merged
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Feb 19, 2021
@rashmivkulkarni
Unskip and Fix maps x-pack functional test - ( sample data and layer_…
7c795b4 
…errors) and also added baseline images (elastic#91205)

* fixes elastic#74449

* unskip maps tests (elastic#90323)

* unskip maps tests

* checking the baseline images

* updated the test to move the mouse away and close the Legend

* more changes to the test

* reducing the threshold limit

* updating the baseline images

* added a comment about the baseline images

* updating flights baseline image and adjusting threshold

* updated threshold and baseline image for web log

* session image of weblogsmap

* skipping layer_errors test

* skip the test - as it fails on cloud and windows on snapshot
@rashmivkulkarni rashmivkulkarni mentioned this pull request Feb 19, 2021
Merged
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Feb 19, 2021
@rashmivkulkarni
Unskip and Fix maps x-pack functional test - ( sample data and layer_…
d9a1c08 
…errors) and also added baseline images (elastic#91205)

* fixes elastic#74449

* unskip maps tests (elastic#90323)

* unskip maps tests

* checking the baseline images

* updated the test to move the mouse away and close the Legend

* more changes to the test

* reducing the threshold limit

* updating the baseline images

* added a comment about the baseline images

* updating flights baseline image and adjusting threshold

* updated threshold and baseline image for web log

* session image of weblogsmap

* skipping layer_errors test

* skip the test - as it fails on cloud and windows on snapshot
rashmivkulkarni added a commit that referenced this pull request Feb 19, 2021
@rashmivkulkarni
Unskip and Fix maps x-pack functional test - ( sample data and layer_…
0fac077 
…errors) and also added baseline images (#91205) (#91973)

* fixes #74449

* unskip maps tests (#90323)

* unskip maps tests

* checking the baseline images

* updated the test to move the mouse away and close the Legend

* more changes to the test

* reducing the threshold limit

* updating the baseline images

* added a comment about the baseline images

* updating flights baseline image and adjusting threshold

* updated threshold and baseline image for web log

* session image of weblogsmap

* skipping layer_errors test

* skip the test - as it fails on cloud and windows on snapshot
rashmivkulkarni added a commit that referenced this pull request Feb 19, 2021
@rashmivkulkarni
Unskip and Fix maps x-pack functional test - ( sample data and layer_…
dcf6336 
…errors) and also added baseline images (#91205) (#91972)

* fixes #74449

* unskip maps tests (#90323)

* unskip maps tests

* checking the baseline images

* updated the test to move the mouse away and close the Legend

* more changes to the test

* reducing the threshold limit

* updating the baseline images

* added a comment about the baseline images

* updating flights baseline image and adjusting threshold

* updated threshold and baseline image for web log

* session image of weblogsmap

* skipping layer_errors test

* skip the test - as it fails on cloud and windows on snapshot
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 19, 2021
@nreese nreese mentioned this pull request Mar 22, 2021
Closed
@nreese nreese mentioned this pull request May 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindsun kindsun kindsun approved these changes

@LeeDr LeeDr LeeDr approved these changes

Assignees

@rashmivkulkarni rashmivkulkarni

Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes test_xpack_functional v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rashmivkulkarni @elasticmachine @kibanamachine @kindsun @LeeDr