Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] clamp MVT too many features polygon to tile boundary #90444

Merged
merged 3 commits into from
Feb 8, 2021

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Feb 5, 2021

#90194 is blocked, but while working on that PR, it became apparent that the too many features bounding box needs to be clamped to the tile boundary since shapes may extend the boundary past the tile bounds.

#90194 also moved mapbox style verification from the join functional test to its own test suite since it did not make sense to include in the join functional test suite.

@nreese nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 5, 2021
@nreese nreese requested a review from thomasneirynck February 5, 2021 16:02
@nreese nreese requested a review from a team as a code owner February 5, 2021 16:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Feb 8, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for extracting this, and the simplifications

@nreese nreese merged commit 3722bea into elastic:master Feb 8, 2021
nreese added a commit to nreese/kibana that referenced this pull request Feb 8, 2021
…90444)

* [Maps] clamp MVT too many features polygon to tile boundary

* add mapbox_styles to index.js

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
nreese added a commit that referenced this pull request Feb 8, 2021
…90674)

* [Maps] clamp MVT too many features polygon to tile boundary

* add mapbox_styles to index.js

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants