Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Time To Visualize] Make State Transfer App Specific #89804

Merged
merged 8 commits into from
Feb 8, 2021
Merged

[Time To Visualize] Make State Transfer App Specific #89804

merged 8 commits into from
Feb 8, 2021

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Jan 29, 2021 •
edited
Loading

Summary

Fixes #89798 by making the state transfer store appId along with the state to be transferred.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 Project:TimeToVisualize v7.12.0 labels Jan 29, 2021
@ThomThomson ThomThomson marked this pull request as ready for review February 1, 2021 19:56
@ThomThomson ThomThomson requested a review from a team February 1, 2021 19:56
@ThomThomson ThomThomson requested review from a team as code owners February 1, 2021 19:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

flash1293
flash1293 approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Visualize and Lens charts and adding/editing panels still works fine (both for by reference and by value). LGTM

@botelastic botelastic bot added the Feature:Embedding Embedding content via iFrame label Feb 2, 2021
clintandrewhall
clintandrewhall approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@clintandrewhall clintandrewhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good solution. LGTM

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

@ThomThomson
Copy link
Contributor Author

@elasticmachine merge upstream

streamich
streamich approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM.

@kibanamachine
Copy link
Contributor

💔 Build Failed

Metrics [docs]

‼️ ERROR: metrics for 458f236 were not reported

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ThomThomson ThomThomson merged commit 31a3ec5 into elastic:master Feb 8, 2021
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Feb 8, 2021
@ThomThomson
[Time To Visualize] Make State Transfer App Specific (elastic#89804)
4cf8011 
* made state transfer app specific
@ThomThomson ThomThomson mentioned this pull request Feb 8, 2021
Merged
ThomThomson added a commit to ThomThomson/kibana that referenced this pull request Feb 8, 2021
@ThomThomson
[Time To Visualize] Make State Transfer App Specific (elastic#89804)
76f3bfe 
* made state transfer app specific
# Conflicts:
#	src/plugins/embeddable/public/public.api.md
#	src/plugins/visualize/public/application/components/visualize_byvalue_editor.tsx
#	src/plugins/visualize/public/application/components/visualize_editor.tsx
#	src/plugins/visualize/public/application/components/visualize_listing.tsx
#	src/plugins/visualize/public/plugin.ts
#	x-pack/plugins/lens/public/plugin.ts
@ThomThomson ThomThomson mentioned this pull request Feb 8, 2021
Merged
ThomThomson added a commit that referenced this pull request Feb 8, 2021
@ThomThomson
[Time To Visualize] Make State Transfer App Specific (#89804) (#90676)
5b861f7 
* made state transfer app specific
ThomThomson added a commit that referenced this pull request Feb 9, 2021
@ThomThomson
[7.11] [Time To Visualize] Make State Transfer App Specific (#89804) (#…
047edb4 
…90679)

* [Time To Visualize] Make State Transfer App Specific (#89804)
Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
@ThomThomson ThomThomson mentioned this pull request Feb 10, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clintandrewhall clintandrewhall clintandrewhall approved these changes

@flash1293 flash1293 flash1293 approved these changes

@streamich streamich streamich approved these changes

Assignees
No one assigned
Labels
Feature:Dashboard Dashboard related features Feature:Embedding Embedding content via iFrame Project:TimeToVisualize release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.11.1 v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Time To Visualize] State Transfer is not App Specific
6 participants
@ThomThomson @elasticmachine @kibanamachine @clintandrewhall @flash1293 @streamich