[ML] Fix synching jobs from other spaces #86086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Dec 16, 2020
There was a problem hiding this comment.
Tested and LGTM.
During testing, I noticed the line spacing is wrong here:
Could you please edit
modified: public/application/jobs/jobs_list/components/delete_job_modal/delete_job_modal.tsx
modified: public/application/jobs/jobs_list/components/delete_job_modal/delete_job_modal_.js
and wrap the <FormattedMessage> for that error inside an <EuiText>.
|
@elasticmachine merge upstream |
…yelastic/kibana into fix-syncing-jobs-from-other-spaces
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Dec 17, 2020
* [ML] Fix synching jobs from other spaces * updating text in delete modal * updating translations Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jgowdyelastic
added a commit
that referenced
this pull request
Dec 17, 2020
* [ML] Fix synching jobs from other spaces * updating text in delete modal * updating translations Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
jgowdyelastic
added a commit
that referenced
this pull request
Dec 17, 2020
* [ML] Fix synching jobs from other spaces * updating text in delete modal * updating translations Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue where running synchronise on left over saved objects which are only tagged to other spaces causes an error ro be returned.
fixes issue raised here:
#85794 (comment)
Unit or functional tests were updated or added to match the most common scenarios
This was checked for breaking API changes and was labeled appropriately